Address httpoxy vulnerability #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 22, 2016 11:19
| @@ -1 +1 @@ | |||
| 0.7.0 No newline at end of file | |||
| 1.0.0 No newline at end of file | |||
There was a problem hiding this comment.
Do we want to stick with the pre-1.0 versions? if so this should be 0.8.0
There was a problem hiding this comment.
We should definitely bump the major version if this is an API-breaking change.
There was a problem hiding this comment.
I'm fine either way, but FYI: http://semver.org/#spec-item-4
|
lgtm |
eli-darkly
added a commit
that referenced
this pull request
Jan 31, 2019
add option to reduce front-end metadata for untracked flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #30
Involves upgrading Guzzle to 6.2.1 which means we need a new http client cache: https://github.com/Kevinrob/guzzle-cache-middleware
This is an api-breaking change since the cache storage interface is different. Documentation/examples will need to be updated when actually releasing.
Deployed to restwrapper and harness passes: https://circleci.com/gh/launchdarkly/integration-harness/1347
Manually tested that the client does indeed cache things.